linux-kernel - [PATCH] memcg: Provide knob for force OOM into the memcg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Dec 2014 18:55:35 +0530
From:	Chintan Pandya <cpandya@...eaurora.org>
To:	mhocko@...e.cz, hannes@...xchg.org, linux-mm@...ck.org,
	cgroups@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org,
	Chintan Pandya <cpandya@...eaurora.org>
Subject: [PATCH] memcg: Provide knob for force OOM into the memcg

We may want to use memcg to limit the total memory
footprint of all the processes within the one group.
This may lead to a situation where any arbitrary
process cannot get migrated to that one  memcg
because its limits will be breached. Or, process can
get migrated but even being most recently used
process, it can get killed by in-cgroup OOM. To
avoid such scenarios, provide a convenient knob
by which we can forcefully trigger OOM and make
a room for upcoming process.

To trigger force OOM,
$ echo 1 > /<memcg_path>/memory.force_oom

Signed-off-by: Chintan Pandya <cpandya@...eaurora.org>
---
 mm/memcontrol.c | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index ef91e85..4c68aa7 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -3305,6 +3305,30 @@ static int mem_cgroup_force_empty(struct mem_cgroup *memcg)
 	return 0;
 }
 
+static int mem_cgroup_force_oom(struct cgroup *cont, unsigned int event)
+{
+	struct mem_cgroup *memcg = mem_cgroup_from_cont(cont);
+	int ret;
+
+	if (mem_cgroup_is_root(memcg))
+		return -EINVAL;
+
+	css_get(&memcg->css);
+	ret = mem_cgroup_handle_oom(memcg, GFP_KERNEL, 0);
+	css_put(&memcg->css);
+
+	return ret;
+}
+
+static int mem_cgroup_force_oom_write(struct cgroup *cgrp,
+				struct cftype *cft, u64 val)
+{
+	if (val > 1 || val < 1)
+		return -EINVAL;
+
+	return mem_cgroup_force_oom(cgrp, 0);
+}
+
 static ssize_t mem_cgroup_force_empty_write(struct kernfs_open_file *of,
 					    char *buf, size_t nbytes,
 					    loff_t off)
@@ -4442,6 +4466,11 @@ static struct cftype mem_cgroup_files[] = {
 		.write = mem_cgroup_force_empty_write,
 	},
 	{
+		.name = "force_oom",
+		.trigger = mem_cgroup_force_oom,
+		.write_u64 = mem_cgroup_force_oom_write,
+	},
+	{
 		.name = "use_hierarchy",
 		.write_u64 = mem_cgroup_hierarchy_write,
 		.read_u64 = mem_cgroup_hierarchy_read,
-- 
Chintan Pandya

QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member of the Code Aurora Forum, hosted by The Linux Foundation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/