linux-kernel - Re: [PATCH 1/2] ARM: omap5/dra7xx: Fix frequency typos.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141216163951.GM24110@csclub.uwaterloo.ca>
Date:	Tue, 16 Dec 2014 11:39:51 -0500
From:	"Lennart Sorensen" <lsorense@...lub.uwaterloo.ca>
To:	Nishanth Menon <nm@...com>
Cc:	linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/2] ARM: omap5/dra7xx: Fix frequency typos.

On Tue, Dec 16, 2014 at 08:06:34AM -0600, Nishanth Menon wrote:
> On 12/12/2014 04:08 PM, Lennart Sorensen wrote:
> > The switch statement of the possible list of SYSCLK1 frequencies is
> > missing a 0 in 4 out of the 7 frequencies.
> > 
> > Signed-off-by: Len Sorensen <lsorense@...lub.uwaterloo.ca>
> > ---
> >  arch/arm/mach-omap2/timer.c |    8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c
> > index 4f61148..fb0cb2b 100644
> > --- a/arch/arm/mach-omap2/timer.c
> > +++ b/arch/arm/mach-omap2/timer.c
> > @@ -513,11 +513,11 @@ static void __init realtime_counter_init(void)
> >  	rate = clk_get_rate(sys_clk);
> >  	/* Numerator/denumerator values refer TRM Realtime Counter section */
> >  	switch (rate) {
> > -	case 1200000:
> > +	case 12000000:
> >  		num = 64;
> >  		den = 125;
> >  		break;
> > -	case 1300000:
> > +	case 13000000:
> >  		num = 768;
> >  		den = 1625;
> >  		break;
> > @@ -529,11 +529,11 @@ static void __init realtime_counter_init(void)
> >  		num = 192;
> >  		den = 625;
> >  		break;
> > -	case 2600000:
> > +	case 26000000:
> >  		num = 384;
> >  		den = 1625;
> >  		break;
> > -	case 2700000:
> > +	case 27000000:
> >  		num = 256;
> >  		den = 1125;
> >  		break;
> > 
> 
> 
> Also please add:
> Fixes: fa6d79d27614 ("ARM: OMAP: Add initialisation for the real-time
> counter")
> 
> With that,
> 
> Acked-by: Nishanth Menon <nm@...com>

Should I send a new version with that added, or will someone else handle
doing that bit?

-- 
Len Sorensen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/