linux-kernel - Re: [PATCH 1/8] drivers: watchdog: Fixed missing blank line warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141216164444.GC26966@roeck-us.net>
Date:	Tue, 16 Dec 2014 08:44:44 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Athira Lekshmi <andnlnbn18@...il.com>
Cc:	wim@...ana.be, linux-watchdog@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/8] drivers: watchdog: Fixed missing blank line warning

On Tue, Dec 16, 2014 at 09:55:22PM +0530, Athira Lekshmi wrote:
> Added a new line after declarations to remove the warning:

'Add', per SubmittingPatches, Chapter 2.

You might also want to add that this is a checkpatch warning
(not a compiler warning).

> 'Missing blank line after declarations'
> 

"drivers" in the subject line of your patches is irrelevant. 
On the other side, the actual drivers you are touching are missing,
resulting in eight identical subject lines. That is not really helpful.

Use something like "watchdog: wdt_pci: ..." to give the maintainer
a hint about the modified driver.

Guenter

> Signed-off-by: Athira Lekshmi <andnlnbn18@...il.com>
> ---
>  drivers/watchdog/wdt_pci.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/watchdog/wdt_pci.c b/drivers/watchdog/wdt_pci.c
> index 48b2c05..b84a180 100644
> --- a/drivers/watchdog/wdt_pci.c
> +++ b/drivers/watchdog/wdt_pci.c
> @@ -279,6 +279,7 @@ static int wdtpci_get_temperature(int *temperature)
>  {
>  	unsigned short c;
>  	unsigned long flags;
> +
>  	spin_lock_irqsave(&wdtpci_lock, flags);
>  	c = inb(WDT_RT);
>  	udelay(8);
> @@ -366,6 +367,7 @@ static ssize_t wdtpci_write(struct file *file, const char __user *buf,
>  
>  			for (i = 0; i != count; i++) {
>  				char c;
> +
>  				if (get_user(c, buf + i))
>  					return -EFAULT;
>  				if (c == 'V')
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/