linux-kernel - Re: [PATCH 1/2] ARM: dts: kirkwood: enable phy driver for SATA controller on 88f6192

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141216181913.GF20170@anne>
Date:	Tue, 16 Dec 2014 19:19:13 +0100
From:	Evgeni Dobrev <evgeni@...dio-punkt.com>
To:	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
Cc:	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/2] ARM: dts: kirkwood: enable phy driver for SATA
 controller on 88f6192

Hello Thomas,

On Tue, Dec 16, 2014 at 05:01:38PM +0100, Thomas Petazzoni wrote:
> Dear Evgeni Dobrev,
> 
> On Mon, 15 Dec 2014 21:37:24 +0100, Evgeni Dobrev wrote:
> > This patch enables the phy drivers for the SATA controller on Marvell's 88f6192. Without them it is not possible to use SATA drives attached to this processor.
> 
> Commit log text should be wrapped to some reasonable length.
> 

I will fix this.

> 
> >  			interrupts = <21>;
> >  			clocks = <&gate_clk 14>, <&gate_clk 15>;
> >  			clock-names = "0", "1";
> > +                        phys = <&sata_phy0>, <&sata_phy1>;
> > +                        phy-names = "port0", "port1";
> 
> You should use tabs and not spaces for indentation in Device Tree files.

I will resubmit. Thank you for your review.

> 
> Thanks!
> 
> Thomas
> -- 
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
> --

evgeni
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/