linux-kernel - Re: [PATCH 2/2] ARM: dts: kirkwood: add dts support for Seagate BlackArmor NAS220

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141216192020.GB12820@lunn.ch>
Date:	Tue, 16 Dec 2014 20:20:20 +0100
From:	Andrew Lunn <andrew@...n.ch>
To:	Evgeni Dobrev <evgeni@...dio-punkt.com>
Cc:	Andrew Lunn <andrew@...n.ch>, devicetree@...r.kernel.org,
	Jason Cooper <jason@...edaemon.net>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...glemail.com>,
	linux-kernel@...r.kernel.org,
	Gregory Clement <gregory.clement@...e-electrons.com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/2] ARM: dts: kirkwood: add dts support for Seagate
 BlackArmor NAS220

> The LED can be either one of the two colors or off. Swapping the
> polarity on the two LED pins changes the color.

O.K, so it is using the diode property of a Light Emitting Diode, to
support two colours.

> I am currently playing with the idea to create a multicolor LED kernel 
> driver which is being controlled via GPIOs, but I still have not found 
> the proper abstraction for it.

Maybe multi-colour is too far. Just support bi-colour via two gpios.
Still, it is not so simple. As you said, the led class does not give
too good an abstraction. I guess the best you can do is that when you
turn one on, it automagically turns the other off.

> The point is, that even though this functionality must currently be
> handled by user space (some combination of sysfs writes and a shell
> script) at the moment, the rest of the system is usable.

Sure, we will take the DT file without support for the bicolour
LED. It can be added later.

      Andrew
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/