linux-kernel - Re: [PATCH 8/9] virtio_pci: split out legacy device support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141216225526.GA19694@redhat.com>
Date:	Wed, 17 Dec 2014 00:55:26 +0200
From:	"Michael S. Tsirkin" <mst@...hat.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	linux-kernel@...r.kernel.org, rusty@...tcorp.com.au,
	virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH 8/9] virtio_pci: split out legacy device support

On Wed, Dec 17, 2014 at 08:03:10AM +1100, Herbert Xu wrote:
> Michael S. Tsirkin <mst@...hat.com> wrote:
> > Move everything dealing with legacy devices out to virtio_pci_legacy.c.
> > Expose common code APIs in virtio_pci.h
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
> 
> This breaks virtio_pci because you deleted the licence from it.
> 
> -- >8 --
> Subject: virtio_pci: Restore module licence and other attributes
> 
> When the virtio_pci driver was moved into virtio_pci_legacy.c the
> module licence and other attributes went AWOL.  This patch restores
> them.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Thanks!
I'll apply a similar patch but to virtio_pci_common.
Will send a pull request with this included tomorrow.

> diff --git a/drivers/virtio/virtio_pci_legacy.c b/drivers/virtio/virtio_pci_legacy.c
> index 2588252..6b100e3 100644
> --- a/drivers/virtio/virtio_pci_legacy.c
> +++ b/drivers/virtio/virtio_pci_legacy.c
> @@ -324,3 +324,8 @@ static struct pci_driver virtio_pci_driver = {
>  };
>  
>  module_pci_driver(virtio_pci_driver);
> +
> +MODULE_AUTHOR("Anthony Liguori <aliguori@...ibm.com>");
> +MODULE_DESCRIPTION("virtio-pci");
> +MODULE_LICENSE("GPL");
> +MODULE_VERSION("1");
> 
> Cheers,
> -- 
> Email: Herbert Xu <herbert@...dor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/