linux-kernel - Re: [PATCH 05/18] perf evlist: Do not use hard coded value for a mmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141217132330.GB18257@krava.brq.redhat.com>
Date:	Wed, 17 Dec 2014 14:23:30 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:	Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Borislav Petkov <bp@...e.de>, David Ahern <dsahern@...il.com>,
	Don Zickus <dzickus@...hat.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Mike Galbraith <efault@....de>,
	Namhyung Kim <namhyung@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 05/18] perf evlist: Do not use hard coded value for a
 mmap_pages default

On Tue, Dec 16, 2014 at 01:57:07PM -0300, Arnaldo Carvalho de Melo wrote:
> From: Arnaldo Carvalho de Melo <acme@...hat.com>
> 
> So far what is in there by default is what we were using: 512KB + the
> control page, but the admin may change that, and if it does to a smaller
> value, all calls to tooling for non root users start failing, requiring
> that the user manually set --mmap_pages/-m.
> 
> Use instead what is in /proc/sys/kernel/perf_event_mlock_kb.
> 
> Cc: Adrian Hunter <adrian.hunter@...el.com>
> Cc: Borislav Petkov <bp@...e.de>
> Cc: David Ahern <dsahern@...il.com>
> Cc: Don Zickus <dzickus@...hat.com>
> Cc: Frederic Weisbecker <fweisbec@...il.com>
> Cc: Jiri Olsa <jolsa@...hat.com>
> Cc: Mike Galbraith <efault@....de>
> Cc: Namhyung Kim <namhyung@...nel.org>
> Cc: Paul Mackerras <paulus@...ba.org>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Stephane Eranian <eranian@...gle.com>
> Link: http://lkml.kernel.org/n/tip-2f6mtm8xu3wo5lhkql6jdblh@git.kernel.org
> Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
> ---
>  tools/perf/util/evlist.c | 20 ++++++++++++++++----
>  1 file changed, 16 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
> index 7847f3885081..ac808680e61c 100644
> --- a/tools/perf/util/evlist.c
> +++ b/tools/perf/util/evlist.c
> @@ -893,10 +893,22 @@ out_unmap:
>  
>  static size_t perf_evlist__mmap_size(unsigned long pages)
>  {
> -	/* 512 kiB: default amount of unprivileged mlocked memory */
> -	if (pages == UINT_MAX)
> -		pages = (512 * 1024) / page_size;
> -	else if (!is_power_of_2(pages))
> +	if (pages == UINT_MAX) {
> +		int max;
> +
> +		if (sysctl__read_int("kernel/perf_event_mlock_kb", &max) < 0) {
> +			/*
> +			 * Pick a once upon a time good value, i.e. things look
> +			 * strange since we can't read a sysctl value, but lets not
> +			 * die yet...
> +			 */
> +			max = 512;
> +		} else {
> +			max -= (page_size / 1024);
> +		}

so this way you depend on value in perf_event_mlock_kb being power 2,
otherwise:

# echo 1000 > /proc/sys/kernel/perf_event_mlock_kb
$ perf record ls
failed to mmap with 22 (Invalid argument)

maybe you could use the logic/code from parse_pages_arg function

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/