[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.DEB.2.10.1412171636400.23841@chino.kir.corp.google.com>
Date: Wed, 17 Dec 2014 16:38:10 -0800 (PST)
From: David Rientjes <rientjes@...gle.com>
To: Andrey Ryabinin <a.ryabinin@...sung.com>
cc: akpm@...ux-foundation.org, Dmitry Vyukov <dvyukov@...gle.com>,
Manfred Spraul <manfred@...orfullife.com>,
Naoya Horiguchi <n-horiguchi@...jp.nec.com>,
Luiz Capitulino <lcapitulino@...hat.com>,
"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
"nadia.derbey@...l.net" <Nadia.Derbey@...l.net>, aquini@...hat.com,
Joe Perches <joe@...ches.com>, avagin@...nvz.org,
LKML <linux-kernel@...r.kernel.org>,
Kostya Serebryany <kcc@...gle.com>,
Dmitry Chernenkov <dmitryc@...gle.com>,
Andrey Konovalov <andreyknvl@...gle.com>,
Konstantin Khlebnikov <koct9i@...il.com>,
kasan-dev <kasan-dev@...glegroups.com>,
Davidlohr Bueso <dave@...olabs.net>, linux-mm@...ck.org
Subject: Re: [PATCH 1/2] hugetlb, sysctl: pass '.extra1 = NULL' rather then
'.extra1 = &zero'
On Wed, 17 Dec 2014, Andrey Ryabinin wrote:
> Commit ed4d4902ebdd ("mm, hugetlb: remove hugetlb_zero and hugetlb_infinity") replaced
> 'unsigned long hugetlb_zero' with 'int zero' leading to out-of-bounds access
> in proc_doulongvec_minmax().
> Use '.extra1 = NULL' instead of '.extra1 = &zero'. Passing NULL is equivalent to
> passing minimal value, which is 0 for unsigned types.
>
> Reported-by: Dmitry Vyukov <dvyukov@...gle.com>
> Suggested-by: Manfred Spraul <manfred@...orfullife.com>
> Fixes: ed4d4902ebdd ("mm, hugetlb: remove hugetlb_zero and hugetlb_infinity")
> Signed-off-by: Andrey Ryabinin <a.ryabinin@...sung.com>
Acked-by: David Rientjes <rientjes@...gle.com>
Patch title is a little awkward, though, maybe "mm, hugetlb: remove
unnecessary lower bound on sysctl handlers"?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists