[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4170676.z5yoWA4Rtc@wuerfel>
Date: Thu, 18 Dec 2014 08:53:10 +0100
From: Arnd Bergmann <arnd@...aro.org>
To: Chunyan Zhang <zhang.chunyan@...aro.org>
Cc: dwmw2@...radead.org, computersforpeace@...il.com,
john.stultz@...aro.org, linux-mtd@...ts.infradead.org,
linux-kernel@...r.kernel.org, zhang.lyra@...il.com
Subject: Re: [PATCH v3] mtd: test: Replace timeval with ktime_t in speedtest.c and torturetest.c
On Thursday 18 December 2014 11:23:31 Chunyan Zhang wrote:
> This patch changes the 32-bit time type (timeval) to the 64-bit one
> (ktime_t), since 32-bit time types will break in the year 2038.
>
> I use ktime_t instead of timeval to define 'start' and 'finish'
> which are used to get the time for tow points.
>
> This patch also changes do_gettimeofday() to ktime_get() accordingly,
> since ktime_get returns a ktime_t, but do_gettimeofday returns a
> struct timeval, and the other reason is that ktime_get() uses
> the monotonic clock.
>
> This patch is based on another patch which privides a millisecond
> time difference function 'ktime_ms_delta' in ktime.h
>
> http://lkml.iu.edu//hypermail/linux/kernel/1412.2/00625.html
>
> Signed-off-by: Chunyan Zhang <zhang.chunyan@...aro.org>
> Reviewed-by: Arnd Bergmann <arnd@...db.de>
>
The new version still looks good to me, but as there is now a
dependency on another patch, I'd suggest we queue this up in the
y2038 branch together with the patch that introduces ktime_ms_delta.
David or Brian, can you provide an Ack for this, or do you have
any objections?
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists