linux-kernel - Re: [PATCH] ALSA: usb-audio: Fix Scarlett 6i6 initialization typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h4mstl71p.wl-tiwai@suse.de>
Date:	Thu, 18 Dec 2014 09:02:26 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Chris J Arges <chris.j.arges@...onical.com>
Cc:	alsa-devel@...r.kernel.org, Jaroslav Kysela <perex@...ex.cz>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: Fix Scarlett 6i6 initialization typo

At Wed, 17 Dec 2014 16:09:35 -0600,
Chris J Arges wrote:
> 
> The num_controls field was incorrectly set to 0 causing 6i6 to not be
> initialized. Set this to 9.
> 
> Reported-and-tested-by: Mark Roberts <sunifiram@...il.com>
> Signed-off-by: Chris J Arges <chris.j.arges@...onical.com>

Applied, thanks.


Takashi

> ---
>  sound/usb/mixer_scarlett.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/usb/mixer_scarlett.c b/sound/usb/mixer_scarlett.c
> index 9109652..7438e7c 100644
> --- a/sound/usb/mixer_scarlett.c
> +++ b/sound/usb/mixer_scarlett.c
> @@ -655,7 +655,7 @@ static struct scarlett_device_info s6i6_info = {
>  		.names = NULL
>  	},
>  
> -	.num_controls = 0,
> +	.num_controls = 9,
>  	.controls = {
>  		{ .num = 0, .type = SCARLETT_OUTPUTS, .name = "Monitor" },
>  		{ .num = 1, .type = SCARLETT_OUTPUTS, .name = "Headphone" },
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/