linux-kernel - Re: [PATCH] media: rc: Replace timeval with ktime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 18 Dec 2014 19:39:37 +0800
From:	Chunyan Zhang <zhang.chunyan@...aro.org>
To:	Mauro Carvalho Chehab <mchehab@....samsung.com>
Cc:	Arnd Bergmann <arnd@...aro.org>, david@...deman.nu,
	uli-lirc@...-eckhardt.de, hans.verkuil@...co.com,
	julia.lawall@...6.fr, Himangi Saraogi <himangi774@...il.com>,
	Alexey Khoroshilov <khoroshilov@...ras.ru>, joe@...ches.com,
	John Stultz <john.stultz@...aro.org>,
	linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
	Lyra Zhang <zhang.lyra@...il.com>
Subject: Re: [PATCH] media: rc: Replace timeval with ktime_t in imon.c

On Thu, Dec 18, 2014 at 7:00 PM, Mauro Carvalho Chehab
<mchehab@....samsung.com> wrote:
> Em Thu, 18 Dec 2014 17:38:14 +0800
> Chunyan Zhang <zhang.chunyan@...aro.org> escreveu:
>
>> On Thu, Dec 18, 2014 at 3:50 PM, Arnd Bergmann <arnd@...aro.org> wrote:
>> > On Thursday 18 December 2014 11:37:13 Chunyan Zhang wrote:
>> >> This patch changes the 32-bit time type (timeval) to the 64-bit one
>> >> (ktime_t), since 32-bit time types will break in the year 2038.
>> >>
>> >> I use ktime_t instead of all uses of timeval in imon.c
>> >>
>> >> This patch also changes do_gettimeofday() to ktime_get() accordingly,
>> >> since ktime_get returns a ktime_t, but do_gettimeofday returns a
>> >> struct timeval, and the other reason is that ktime_get() uses
>> >> the monotonic clock.
>> >>
>> >> This patch use a new function which is provided by another patch listed below
>> >> to get the millisecond time difference.
>> >
>> > The patch looks great. Just a few small details that could still be
>> > improved:
>
> Yes, patch looks OK. After addressing the bits pointed by Arnd:
>
> Acked-by: Mauro Carvalho Chehab <mchehab@....samsung.com>
>
> Feel free to merge via y2038 tree.
>
Ok, thank you, I'll send the updated patch-set soon.

Chunyan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/