linux-kernel - Re: [PATCH v3 1/2] watchdog: Add driver for Mediatek watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 17 Dec 2014 17:47:45 -0800
From:	Joe Perches <joe@...ches.com>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	Matthias Brugger <matthias.bgg@...il.com>, wim@...ana.be,
	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	grant.likely@...aro.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org,
	heiko@...ech.de, yingjoe.chen@...il.com, ibanezchen@...il.com,
	greta.zhang@...iatek.com, eddie.huang@...iatek.com, wens@...e.org
Subject: Re: [PATCH v3 1/2] watchdog: Add driver for Mediatek watchdog

On Wed, 2014-12-17 at 17:37 -0800, Guenter Roeck wrote:
> On Wed, Dec 17, 2014 at 10:18:04PM +0100, Matthias Brugger wrote:
> > This patch adds a driver for the Mediatek SoC integrated
> > watchdog. This driver supports watchdog and software reset
> > for mt65xx and mt81xx SoCs.
[]
> > diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c
[]
> > +static int mtk_reset_handler(struct notifier_block *this, unsigned long mode,
> > +				void *cmd)
> > +{
> > +	struct mtk_wdt_dev *mtk_wdt = container_of(this,
> > +						       struct mtk_wdt_dev,
> > +						       restart_handler);

> I don't really understand the indentation logic you are using.
> Can you make it consistent ?
> 
> I would suggest to align with '(' in the previous line.

Another way is to separate the declaration and the set

	struct mtk_wdt_dev *mtk_wdt;
	void __iomem *wdt_base;

	mtk_wdt = container_of(this, struct mtk_wdt_dev, restart_handler);
	wdt_base = mtk_wdt->wdt_base;



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/