>From 3d39fd533b4a75e567f76f07f5bc978adddb0721 Mon Sep 17 00:00:00 2001 From: samuel kihahu Date: Thu, 18 Dec 2014 17:42:37 +0300 Subject: [PATCH] staging: speakup: replace simple_strtoul with kstrtoul Replacing obsolete simple_strtoul with kstrtoul, checking and returning the correct error code. Signed-off-by: samuel kihahu --- drivers/staging/speakup/varhandlers.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/staging/speakup/varhandlers.c b/drivers/staging/speakup/varhandlers.c index d758284..716ccc1 100644 --- a/drivers/staging/speakup/varhandlers.c +++ b/drivers/staging/speakup/varhandlers.c @@ -321,9 +321,13 @@ char *spk_strlwr(char *s) char *spk_s2uchar(char *start, char *dest) { - int val = 0; + unsigned long val; + int ret; + + ret = kstrtoul(skip_spaces(start), 10, &val); + if (IS_ERR(&ret)) + return ERR_CAST(&ret); - val = simple_strtoul(skip_spaces(start), &start, 10); if (*start == ',') start++; *dest = (u_char)val; -- 1.8.3.1