linux-kernel - Re: [PATCH v3 1/2] acpi: Add "acpi_osi=" for ASUS X200MA to enable, brightness keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54931AD3.1050305@gmail.com>
Date:	Thu, 18 Dec 2014 21:20:03 +0300
From:	Dmitry Tunin <hanipouspilot@...il.com>
To:	Len Brown <lenb@...nel.org>, Matthew Garrett <mjg59@...f.ucam.org>
CC:	Josh Boyer <jwboyer@...oraproject.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>,
	Aaron Lu <aaron.lu@...el.com>
Subject: Re: [PATCH v3 1/2] acpi: Add "acpi_osi=" for ASUS X200MA to enable,
 brightness keys

Len,

I completely agree that debugging and testing of a real solution would be a problem.
And adding "acpi_osi=" is not too hard as a boot option.

In some cases it can be built-in, if it is a box solution.

So the patch is no good.

18.12.2014 21:09, Len Brown пишет:
> NAK on addoing this acpi_osi= quirk to upstream Linux.
>
> The reason is that problem is being actively debugged.
> Quirks in upstream Linux are for when we give up.
>
> Sure, it is perfectly okay for individual users to invoke it.
> It is even fine for a distro to check in this workaround if they care
> about that box working *now*
> and they are not concerned about side effects.
>
> But the real fix is in development, and checking workarounds with
> possible other side-effects
> into up-stream Linux is just a distraction from getting it right for
> not just this machine,
> but other machines w/ the same issue.
>
> thanks,
> Len Brown, Intel Open Source Technology Center
>
> ps. lots of people are mis-using acpi_osi= in debugging, please consult
> Documentation/kernel-parameters.txt for a detailed description of how
> this cmdline option works.  Note, in particular, that acpi_osi=XYZ by itself
> will _add_ XYZ to the list of recognized strings.  If that string is
> already built
> into Linux (eg. "Windows 2012"), then adding it again has no effect.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/