lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Thu, 18 Dec 2014 11:53:25 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Ethan Zhao <ethan.zhao@...cle.com>
Cc:	Dirk Brandewie <dirk.j.brandewie@...el.com>,
	kristen@...ux.intel.com, "Rafael J. Wysocki" <rjw@...ysocki.net>,
	Linda Knippers <linda.knippers@...com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	ethan.kernel@...il.com
Subject: Re: [PATCH V2] cpufreq: fix a NULL pointer dereference triggered by
 _PPC changed notification

On 18 December 2014 at 11:50, Ethan Zhao <ethan.zhao@...cle.com> wrote:
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 4473eba..b75735c 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -2021,6 +2021,11 @@ static int __cpufreq_governor(struct cpufreq_policy *policy,
>         /* Don't start any governor operations if we are entering suspend */
>         if (cpufreq_suspended)
>                 return 0;
> +       /* Governor might not be initiated here if _PPC changed notification
> +        * happened, check it.
> +        */

Its still wrong.

/*
 * Governor might not be initiated here if _PPC changed notification
 * happened, check it.
 */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ