linux-kernel - RE: [DISCUSSION] USB device remote wakeup is not working for S3 case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0C18FE92A7765D4EB9EE5D38D86A563A01C42A57@SHSMSX103.ccr.corp.intel.com>
Date:	Fri, 19 Dec 2014 06:55:55 +0000
From:	"Du, Changbin" <changbin.du@...el.com>
To:	Alan Stern <stern@...land.harvard.edu>
CC:	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Wu, Hao" <hao.wu@...el.com>
Subject: RE: [DISCUSSION] USB device remote wakeup is not working for S3 case

> There's a simple solution: Call device_set_wakeup_enable() for the device!
> You can do this from the command line by:
> 
> 	echo auto >/sys/bus/usb/devices/.../power/control
> 
> where the "..." is the pathname for your device.
> 
Yes, this can enable auto-suspend for usb device like a mouse. And remote wakeup
does work for RPM because rpm suspend refers to the needs_remote_wakeup flag.
But this doesn't impact system level suspend. The correct thing is:
	
	echo enabled >/sys/bus/usb/devices/.../power/wakeup

This will call device_set_wakeup_enable() for the device and should work. But 
unfortunately it seems didn't work even the wakeup file shows "enabled" which 
means the device is wakeup enabled(Tried on 3.16 & 3.18 kernel). This is a different
issue, I will check.

> 	if (interface->desc.bInterfaceSubClass ==
> USB_INTERFACE_SUBCLASS_BOOT &&
> 			interface->desc.bInterfaceProtocol ==
> 				USB_INTERFACE_PROTOCOL_KEYBOARD) {
> 		usbhid_set_leds(hid);
> 		device_set_wakeup_enable(&dev->dev, 1);
> 	}
> 
> How about leaving everything the way it is now?  If you want to enable
> wakeup for something like a USB mouse, you can write a udev script to do it
> as shown above.
> 
> Alan Stern

Could we also enable wakeup for usb mouse? Or is there any concern to enable it?
Per my opinion, most people may expect clicking mouse can awake system.

Regards,
Du, Changbin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/