linux-kernel - Re: [PATCH RESEND v2 03/10] power: charger-manager: Remove deprecated function, cm_notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-id: <1255984171.39711418975524329.JavaMail.weblogic@epmlwas08d>
Date:	Fri, 19 Dec 2014 07:52:04 +0000 (GMT)
From:	MyungJoo Ham <myungjoo.ham@...sung.com>
To:	이종화 <jonghwa3.lee@...sung.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"sre@...nel.org" <sre@...nel.org>,
	"dbaryshkov@...il.com" <dbaryshkov@...il.com>,
	"dwmw2@...radead.org" <dwmw2@...radead.org>,
	"anton@...msg.org" <anton@...msg.org>,
	"pavel@....cz" <pavel@....cz>,
	최찬우 <cw00.choi@...sung.com>
Subject: Re: [PATCH RESEND v2 03/10] power: charger-manager: Remove deprecated
 function, cm_notify_event().

>   
>  cm_notify_event() is introduced to get event associated with battery status
> externally, but no one had been used. Moreover it makes charger manager
> driver more complicated. This patch tries to drop the function and all data
> related to simplify the driver.
> 
> Signed-off-by: Jonghwa Lee <jonghwa3.lee@...sung.com>

You are not just removing cm_notify_event() and its related.

You are hereby removing the much of software charger control
and suspend-related operations. Could you please be more specific
on why? (many of such features are to comply with operators' requirements)

(Or we may meet next Monday for some discussions :) )

> ---
>  .../bindings/power_supply/charger-manager.txt      |    1 -
>  drivers/power/charger-manager.c                    |  196 +-------------------
>  include/linux/power/charger-manager.h              |   19 +-
>  3 files changed, 8 insertions(+), 208 deletions(-)
>