lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:	Fri, 19 Dec 2014 17:45:27 +0800
From:	kbuild test robot <fengguang.wu@...el.com>
To:	Alan Tull <atull@...nsource.altera.com>
Cc:	kbuild-all@...org, Michal Simek <monstr@...str.eu>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: [PATCH] staging: fpga manager: fix odd_ptr_err.cocci warnings

drivers/staging/fpga/socfpga.c:647:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 648

 PTR_ERR should access the value just tested by IS_ERR

Semantic patch information:
 There can be false positives in the patch case, where it is the call
 IS_ERR that is wrong.

Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci

CC: Alan Tull <atull@...nsource.altera.com>
Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
---

 socfpga.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/staging/fpga/socfpga.c
+++ b/drivers/staging/fpga/socfpga.c
@@ -645,7 +645,7 @@ static int socfpga_fpga_probe(struct pla
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
 	priv->fpga_data_addr = devm_ioremap_resource(dev, res);
 	if (IS_ERR(priv->fpga_data_addr))
-		return PTR_ERR(priv->fpga_base_addr);
+		return PTR_ERR(priv->fpga_data_addr);
 
 	priv->irq = platform_get_irq(pdev, 0);
 	if (priv->irq < 0)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ