| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1418951998.4830.7.camel@haakon3.risingtidesystems.com> Date: Thu, 18 Dec 2014 17:19:58 -0800 From: "Nicholas A. Bellinger" <nab@...ux-iscsi.org> To: Kyle McMartin <kyle@...hat.com> Cc: linux-kernel@...r.kernel.org, agrover@...hat.com, jbastian@...hat.com, target-devel <target-devel@...r.kernel.org> Subject: Re: [PATCH] uapi/linux/target_core_user.h: fix headers_install.sh badness Hi Kyle, On Thu, 2014-12-18 at 12:57 -0500, Kyle McMartin wrote: > scripts/headers_install.sh will transform __packed to > __attribute__((packed)), so the #ifndef is not necessary. > (and, in fact, it's problematic, because we'll end up with the header > containing: > #ifndef __attribute__((packed)) > #define __attribu... > and so forth.) > > Cc: stable@...r.kernel.org # 3.18 > Signed-off-by: Kyle McMartin <kyle@...hat.com> > > --- > cc-ing stable@ so this headers fix gets picked up by distros. > > --- a/include/uapi/linux/target_core_user.h > +++ b/include/uapi/linux/target_core_user.h > @@ -6,10 +6,6 @@ > #include <linux/types.h> > #include <linux/uio.h> > > -#ifndef __packed > -#define __packed __attribute__((packed)) > -#endif > - > #define TCMU_VERSION "1.0" > > /* Applied to target-pending/for-next. Thanks! --nab -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists