linux-kernel - [PATCH] drm/fb-helper: fix simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20141219111413.GA17269@athens>
Date:	Fri, 19 Dec 2014 19:14:13 +0800
From:	kbuild test robot <fengguang.wu@...el.com>
To:	Thierry Reding <treding@...dia.com>
Cc:	kbuild-all@...org, Daniel Vetter <daniel.vetter@...ll.ch>,
	David Airlie <airlied@...ux.ie>,
	Dave Airlie <airlied@...hat.com>,
	Russell King <rmk+kernel@....linux.org.uk>,
	Zach Reizner <zachr@...gle.com>,
	Fabian Frederick <fabf@...net.be>,
	Martin Koegler <martin.koegler@...llo.at>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: [PATCH] drm/fb-helper: fix simple_return.cocci warnings

drivers/gpu/drm/cirrus/cirrus_fbdev.c:330:1-4: WARNING: end returns can be simpified

 Simplify a trivial if-return sequence.  Possibly combine with a
 preceding function call.
Generated by: scripts/coccinelle/misc/simple_return.cocci

CC: Thierry Reding <treding@...dia.com>
Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
---

 cirrus_fbdev.c |    6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

--- a/drivers/gpu/drm/cirrus/cirrus_fbdev.c
+++ b/drivers/gpu/drm/cirrus/cirrus_fbdev.c
@@ -327,11 +327,7 @@ int cirrus_fbdev_init(struct cirrus_devi
 	/* disable all the possible outputs/crtcs before entering KMS mode */
 	drm_helper_disable_unused_functions(cdev->dev);
 
-	ret = drm_fb_helper_initial_config(&gfbdev->helper, bpp_sel);
-	if (ret)
-		return ret;
-
-	return 0;
+	return drm_fb_helper_initial_config(&gfbdev->helper, bpp_sel);
 }
 
 void cirrus_fbdev_fini(struct cirrus_device *cdev)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/