linux-kernel - Re: [PATCH] mtd: ssfdc: Fix space before ( coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141219152013.GA2046@hudson.localdomain>
Date:	Fri, 19 Dec 2014 07:20:13 -0800
From:	Jeremiah Mahler <jmmahler@...il.com>
To:	Mohammad Jamal <md.jamalmohiuddin@...il.com>
Cc:	dwmw2@...radead.org, computersforpeace@...il.com,
	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: ssfdc: Fix space before ( coding style

Mohammad,

On Fri, Dec 19, 2014 at 08:00:13PM +0530, Mohammad Jamal wrote:
> Patch solves the space before ( coding style issue of ssfdc.c
> 
> Signed-off-by: Mohammad Jamal <md.jamalmohiuddin@...il.com>
> ---
>  drivers/mtd/ssfdc.c |   18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/mtd/ssfdc.c b/drivers/mtd/ssfdc.c
> index daf82ba..d4a922c 100644
> --- a/drivers/mtd/ssfdc.c
> +++ b/drivers/mtd/ssfdc.c
> @@ -42,8 +42,8 @@ struct ssfdcr_record {
>  #define MAX_LOGIC_BLK_PER_ZONE	1000
>  #define MAX_PHYS_BLK_PER_ZONE	1024
>  
> -#define KiB(x)	( (x) * 1024L )
> -#define MiB(x)	( KiB(x) * 1024L )
> +#define KiB(x)	((x) * 1024L)
> +#define MiB(x)	(KiB(x) * 1024L)
This looks better than before.

>  
>  /** CHS Table
>  		1MiB	2MiB	4MiB	8MiB	16MiB	32MiB	64MiB	128MiB
> @@ -63,13 +63,13 @@ typedef struct {
>  
>  /* Must be ordered by size */
>  static const chs_entry_t chs_table[] = {
> -	{ MiB(  1), 125,  4,  4 },
> -	{ MiB(  2), 125,  4,  8 },
> -	{ MiB(  4), 250,  4,  8 },
> -	{ MiB(  8), 250,  4, 16 },
> -	{ MiB( 16), 500,  4, 16 },
> -	{ MiB( 32), 500,  8, 16 },
> -	{ MiB( 64), 500,  8, 32 },
> +	{ MiB(1), 125,  4,  4 },
> +	{ MiB(2), 125,  4,  8 },
> +	{ MiB(4), 250,  4,  8 },
> +	{ MiB(8), 250,  4, 16 },
> +	{ MiB(16), 500,  4, 16 },
> +	{ MiB(32), 500,  8, 16 },
> +	{ MiB(64), 500,  8, 32 },
>  	{ MiB(128), 500, 16, 32 },
>  	{ 0 },
>  };
I like the original version better here.  The columns were lined up
nicely and it was easier to read.

-- 
- Jeremiah Mahler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/