linux-kernel - Re: [PATCH v6 4/4] staging: fpga manager: add driver for socfpga fpga manager

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 19 Dec 2014 09:55:34 -0600
From:	atull <atull@...nsource.altera.com>
To:	Steffen Trumtrar <s.trumtrar@...gutronix.de>
CC:	Michal Simek <michal.simek@...inx.com>,
	<gregkh@...uxfoundation.org>, <jgunthorpe@...idianresearch.com>,
	<hpa@...or.com>, <monstr@...str.eu>, <rdunlap@...radead.org>,
	<linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<pantelis.antoniou@...sulko.com>, <robh+dt@...nel.org>,
	<grant.likely@...aro.org>, <iws@...o.caltech.edu>,
	<linux-doc@...r.kernel.org>, <pavel@...x.de>, <broonie@...nel.org>,
	<philip@...ister.org>, <rubini@...dd.com>, <jason@...edaemon.net>,
	<kyle.teske@...com>, <nico@...aro.org>, <balbi@...com>,
	<m.chehab@...sung.com>, <davidb@...eaurora.org>, <rob@...dley.net>,
	<davem@...emloft.net>, <cesarb@...arb.net>,
	<sameo@...ux.intel.com>, <akpm@...ux-foundation.org>,
	<linus.walleij@...aro.org>, <pawel.moll@....com>,
	<mark.rutland@....com>, <ijc+devicetree@...lion.org.uk>,
	<galak@...eaurora.org>, <devel@...verdev.osuosl.org>,
	<delicious.quinoa@...il.com>, <dinguyen@...nsource.altera.com>,
	<yvanderv@...nsource.altera.com>
Subject: Re: [PATCH v6 4/4] staging: fpga manager: add driver for socfpga
 fpga manager

On Fri, 19 Dec 2014, Steffen Trumtrar wrote:

> On Fri, Dec 19, 2014 at 03:05:50PM +0100, Michal Simek wrote:
> > On 12/19/2014 09:55 AM, Steffen Trumtrar wrote:
> > > Hi!
> > > 
> > > Just a minor nitpick, but...
> > > 
> > > On Thu, Dec 18, 2014 at 04:29:08PM -0600, atull@...nsource.altera.com wrote:
> > >> From: Alan Tull <atull@...nsource.altera.com>
> > >>
> > >> Add driver to fpga manager framework to allow configuration
> > >> of FPGA in Altera SoCFPGA parts.
> > >>
> > >> Signed-off-by: Alan Tull <atull@...nsource.altera.com>
> > >> Acked-by: Michal Simek <michal.simek@...inx.com>
> > >> ---
> > >> v2: fpga_manager struct now contains struct device
> > >>     fpga_manager_register parameters now take device
> > >>
> > >> v3: skip a version to align versions
> > >>
> > >> v4: move to drivers/staging
> > >>
> > >> v5: fix array_size.cocci warnings
> > >>     fix platform_no_drv_owner.cocci warnings
> > >>     Remove .owner = THIS_MODULE
> > >>     include asm/irq.h
> > >>     clean up list of includes
> > >>     use altera_fpga_reset for ops
> > >>     use enum fpga_mgr_states or u32 as needed
> > >>     use devm_request_irq
> > >>     check irq <= 0 instead of == NO_IRQ
> > >>     Use ARRAY_SIZE
> > >>     rename altera -> socfpga
> > >>     static const socfpga_fpga_ops
> > >>     header moved to linux/fpga/ folder
> > >>     remove ifdef'ed code
> > >>     use platform_get_resource and platform_get_irq
> > >>     move .probe and .remove lines adjacent
> > >>     use module_platform_driver
> > >>     use __maybe_unused
> > >>     only need to 'if (IS_ENABLED(CONFIG_REGULATOR))' in one fn
> > >>     fix "unsigned 'mode' is never < 0"
> > >>
> > >> v6: return error for (unused) default of case statement
> > >> ---
> > >   ^^^
> > > 
> > > ...if you remove these, than that changelog will not land in the final
> > > commit which I would prefer. Nobody cares for the changelog of a
> > > patch once it is in its final state. And this is a rather noisy one.
> > > When someone in the future looks at this, he will see two lines of
> > > information and 10 times that of uninteresting noise.
> > > 
> > > Not a dealbreaker, but just something to consider for future patches.
> > 
> > 
> > When you run git-am you will see that changelog is not there.
> > 
> 
> Ah, great. It seems like git-am does indeed know now how to handle this.
> There are some commits in mainline that have this changelog added,
> because there where two '---' lines in the patch.
> 
> Then go on kind sirs with whatever you where doing and don't pay any
> attention to my comment... :-)
> 
> Regards,
> Steffen
> 

git format-patch adds the second ---

Alan

> -- 
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/