linux-kernel - Re: [PATCH] net: eth: xgene: change APM X-Gene SoC platform ethernet to support ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20141219.123107.1080751255468272638.davem@davemloft.net>
Date:	Fri, 19 Dec 2014 12:31:07 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	fkan@....com
Cc:	netdev@...r.kernel.org, patches@....com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: eth: xgene: change APM X-Gene SoC platform
 ethernet to support ACPI

From: Feng Kan <fkan@....com>
Date: Thu, 18 Dec 2014 15:39:51 -0800

> +#define NO_MAC_FOUND	0
> +#define RES_ENET_CSR	0
> +#define RES_RING_CSR	1
> +#define RES_RING_CMD	2

Don't define your own magic set of error return semantics.

For example, in the MAC address acquisition case, just verify that
you get an ETH_ALEN length value from the fetch routines and return
-ENODEV or similar if you do not.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/