[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <BLUPR07MB4845BEE1160E5945E113E8AFE6B0@BLUPR07MB484.namprd07.prod.outlook.com>
Date: Fri, 19 Dec 2014 02:34:24 +0000
From: "Chickles, Derek" <Derek.Chickles@...iumnetworks.com>
To: Joe Perches <joe@...ches.com>
CC: "apw@...onical.com" <apw@...onical.com>,
"computersforpeace@...il.com" <computersforpeace@...il.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"cernekee@...il.com" <cernekee@...il.com>
Subject: RE: [PATCH] checkpatch: Fix MAINTAINERS search pattern
> On Thu, 2014-12-18 at 12:12 -0800, Derek Chickles wrote:
> > This fixes the check that was supposed to prevent the MAINTAINERS
> > warning from appearing when you run checkpatch.pl on a patch that
> > includes new files/directories and an updated MAINTAINERS file.
>
> This suggested patch doesn't work.
>
> $realfile isn't set until the file shows up
> in the patch itself.
>
> The current test looks at the changelog
> before the files are modified and is correct.
>
Thanks, you're right. My mistake was trying to run checkpatch.pl on a diff.
My patch works on diffs while the original code does not. This is by chance
really because MAINTAINERS is early in the patch. Using format-patch on
something that is committed is clearly the correct solution.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists