linux-kernel - Re: [PATCH] media: fix au0828_analog_register() to not free au0828

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5494C254.2080306@osg.samsung.com>
Date:	Fri, 19 Dec 2014 17:27:00 -0700
From:	Shuah Khan <shuahkh@....samsung.com>
To:	Shuah Khan <shuah.kh@...sung.com>, m.chehab@...sung.com,
	hans.verkuil@...co.com, prabhakar.csengg@...il.com,
	laurent.pinchart@...asonboard.com
CC:	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: fix au0828_analog_register() to not free au0828_dev

On 12/19/2014 04:42 PM, Shuah Khan wrote:
> From: Shuah Khan <shuahkh@....samsung.com>

Sorry. That doesn't look right. Looks like my gitconfig
is bad. I can resend the patch.

-- Shuah
> 
> au0828_analog_register() frees au0828_dev when it fails to
> locate isoc endpoint. au0828_usb_probe() continues with dvb
> and rc probe and registration assuming dev is still valid.
> When au0828_analog_register() fails to locate isoc endpoint,
> it should return without free'ing au0828_dev. Otherwise, the
> probe will fail as dev is null when au0828_dvb_register() is
> called.
> 
> Signed-off-by: Shuah Khan <shuahkh@....samsung.com>
> ---
>  drivers/media/usb/au0828/au0828-video.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/usb/au0828/au0828-video.c b/drivers/media/usb/au0828/au0828-video.c
> index 3bdf132..94b65b8 100644
> --- a/drivers/media/usb/au0828/au0828-video.c
> +++ b/drivers/media/usb/au0828/au0828-video.c
> @@ -1713,7 +1713,6 @@ int au0828_analog_register(struct au0828_dev *dev,
>  	}
>  	if (!(dev->isoc_in_endpointaddr)) {
>  		pr_info("Could not locate isoc endpoint\n");
> -		kfree(dev);
>  		return -ENODEV;
>  	}
>  
> 


-- 
Shuah Khan
Sr. Linux Kernel Developer
Samsung Open Source Group
Samsung Research America (Silicon Valley)
shuahkh@....samsung.com | (970) 217-8978
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/