linux-kernel - Re: [PATCH v2 1/2] i8k: Autodetect maximal fan speed and fan RPM multiplier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <549565B3.5070504@roeck-us.net>
Date:	Sat, 20 Dec 2014 04:04:03 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Pali Rohár <pali.rohar@...il.com>
CC:	Arnd Bergmann <arnd@...db.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, Valdis.Kletnieks@...edu,
	Steven Honeyman <stevenhoneyman@...il.com>,
	Jean Delvare <jdelvare@...e.de>,
	Gabriele Mazzotta <gabriele.mzt@...il.com>,
	Jochen Eisinger <jochen@...guin-breeder.org>
Subject: Re: [PATCH v2 1/2] i8k: Autodetect maximal fan speed and fan RPM
 multiplier

On 12/20/2014 12:57 AM, Pali Rohár wrote:
> On Friday 19 December 2014 20:28:08 Guenter Roeck wrote:
>> On Fri, Dec 19, 2014 at 07:51:25PM +0100, Pali Rohár wrote:
>>> On Friday 19 December 2014 19:32:37 Guenter Roeck wrote:
>>>>> -static int i8k_fan_mult;
>>>>> -static int i8k_pwm_mult;
>>>>> -static int i8k_fan_max = I8K_FAN_HIGH;
>>>>> +static int i8k_fan_mult[2];
>>>>> +static int i8k_pwm_mult[2];
>>>>> +static int i8k_fan_max[2];
>>>>
>>>> The rationale for this change is not explained in the
>>>> commit log.
>>>>
>>>> Do you have any indication that those values would ever be
>>>> different for the two fans, ie that you actually need
>>>> arrays here ?
>>>
>>> I do not know... But if we decide to use only single value
>>> for multiplier and max value which fan to use for
>>> autodetection?
>>
>> That does not answer my question. That you can not decide
>> which fan to use for auto-detection does not mean that the
>> result of that auto-detection would be different for
>> different fans.
>>
>
> Really I do not know if some dell products which have more fans
> (some Precision models have 2) and each fan is using different
> multiplier or has different max speed value.
>

"I do not know" is not a reason for introducing such code.

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/