linux-kernel - Re: [PATCH] staging: vt6655: fix sparse warnings: incorrect argument type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5496E040.5060408@gmail.com>
Date:	Sun, 21 Dec 2014 14:59:12 +0000
From:	Malcolm Priestley <tvboxspy@...il.com>
To:	Mike Krinkin <krinkin.m.u@...il.com>, gregkh@...uxfoundation.org,
	forest@...ttletooquiet.net, gclement@...bob.org
CC:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: vt6655: fix sparse warnings: incorrect argument
 type



On 21/12/14 13:56, Mike Krinkin wrote:
> this patch fixes following sparse warnings:
>
> drivers/staging/vt6655/device_main.c:1503:25: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/vt6655/device_main.c:1503:25:    expected void [noderef] <asn:2>*<noident>
> drivers/staging/vt6655/device_main.c:1503:25:    got struct vnt_private *
> drivers/staging/vt6655/device_main.c:1503:25: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/vt6655/device_main.c:1503:25:    expected void [noderef] <asn:2>*<noident>
> drivers/staging/vt6655/device_main.c:1503:25:    got struct vnt_private *
> drivers/staging/vt6655/device_main.c:1505:25: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/vt6655/device_main.c:1505:25:    expected void [noderef] <asn:2>*<noident>
> drivers/staging/vt6655/device_main.c:1505:25:    got struct vnt_private *
> drivers/staging/vt6655/device_main.c:1505:25: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/vt6655/device_main.c:1505:25:    expected void [noderef] <asn:2>*<noident>
> drivers/staging/vt6655/device_main.c:1505:25:    got struct vnt_private *
Good catch

also needed for 3.19

Thanks

Malcolm

>
> Signed-off-by: Mike Krinkin <krinkin.m.u@...il.com>
> ---
>   drivers/staging/vt6655/device_main.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
> index 83e4162..ce616f9 100644
> --- a/drivers/staging/vt6655/device_main.c
> +++ b/drivers/staging/vt6655/device_main.c
> @@ -1500,9 +1500,11 @@ static void vnt_bss_info_changed(struct ieee80211_hw *hw,
>   		if (conf->enable_beacon) {
>   			vnt_beacon_enable(priv, vif, conf);
>
> -			MACvRegBitsOn(priv, MAC_REG_TCR, TCR_AUTOBCNTX);
> +			MACvRegBitsOn(priv->PortOffset, MAC_REG_TCR,
> +				      TCR_AUTOBCNTX);
>   		} else {
> -			MACvRegBitsOff(priv, MAC_REG_TCR, TCR_AUTOBCNTX);
> +			MACvRegBitsOff(priv->PortOffset, MAC_REG_TCR,
> +				       TCR_AUTOBCNTX);
>   		}
>   	}
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/