lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 21 Dec 2014 22:50:15 +0100 From: Marek Vasut <marex@...x.de> To: Stefan Wahren <stefan.wahren@...e.com> Cc: mturquette@...aro.org, festevam@...il.com, shawn.guo@...aro.org, harald@...ib.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH] clk: mxs: Fix invalid 32-bit access to frac registers On Sunday, December 21, 2014 at 02:46:39 PM, Stefan Wahren wrote: Hi! [...] > diff --git a/drivers/clk/mxs/clk-ref.c b/drivers/clk/mxs/clk-ref.c > index 4adeed6..bdecec1 100644 > --- a/drivers/clk/mxs/clk-ref.c > +++ b/drivers/clk/mxs/clk-ref.c > @@ -16,6 +16,8 @@ > #include <linux/slab.h> > #include "clk.h" > > +#define BF_CLKGATE BIT(7) > + > /** > * struct clk_ref - mxs reference clock > * @hw: clk_hw for the reference clock > @@ -39,7 +41,7 @@ static int clk_ref_enable(struct clk_hw *hw) > { > struct clk_ref *ref = to_clk_ref(hw); > > - writel_relaxed(1 << ((ref->idx + 1) * 8 - 1), ref->reg + CLR); > + writeb(BF_CLKGATE, ref->reg + ref->idx + CLR); Should this be writeb_relaxed() maybe ? > return 0; > } > @@ -48,7 +50,7 @@ static void clk_ref_disable(struct clk_hw *hw) > { > struct clk_ref *ref = to_clk_ref(hw); > > - writel_relaxed(1 << ((ref->idx + 1) * 8 - 1), ref->reg + SET); > + writeb(BF_CLKGATE, ref->reg + ref->idx + SET); Same here and all around the place ? Other than that, it looks pretty OK :) Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists