linux-kernel - Re: [GIT PULL] one vdso fix for x86/urgent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 21 Dec 2014 11:18:27 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Andy Lutomirski <luto@...capital.net>
Cc:	X86 ML <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Kees Cook <keescook@...omium.org>
Subject: Re: [GIT PULL] one vdso fix for x86/urgent


* Andy Lutomirski <luto@...capital.net> wrote:

> Hi Ingo, etc,
> 
> Please consider pulling for x86/urgent.  This fixes a longstanding,
> albeit relatively minor, issue in the x86 vdso randomization
> algorithm.  Note that this isn't super-urgent, as this bug isn't
> directly exploitable, and it's as old as the vdso itself.
> 
> Thanks,
> Andy
> 
> The following changes since commit e589c9e13aeb0c5539bf1314b3a78442ea8fc0c2:
> 
>   Merge branch 'x86-apic-for-linus' of
> git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip (2014-12-19
> 14:02:02 -0800)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git
> tags/pr-20141220-x86-vdso
> 
> for you to fetch changes up to 394f56fe480140877304d342dec46d50dc823d46:
> 
>   x86_64, vdso: Fix the vdso address randomization algorithm
> (2014-12-20 16:56:57 -0800)
> 
> ----------------------------------------------------------------
> One vdso fix for a longstanding ASLR bug that's been in the news lately.
> 
> The vdso base address has always been randomized, and I don't think there's
> anything particularly wrong with the range over which it's randomized,
> but the implementation seems to have been buggy since the very beginning.
> 
> This fixes the implementation to remove a large bias that caused a small
> fraction of possible vdso load addresess to be vastly more likely than
> the rest of the possible addresses.
> 
> ----------------------------------------------------------------
> Andy Lutomirski (1):
>       x86_64, vdso: Fix the vdso address randomization algorithm
> 
>  arch/x86/vdso/vma.c | 45 +++++++++++++++++++++++++++++----------------
>  1 file changed, 29 insertions(+), 16 deletions(-)

Pulled into tip:x86/urgent, thanks a lot Andy!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/