lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 21 Dec 2014 13:12:47 +0200 From: Oded Gabbay <oded.gabbay@....com> To: Greg KH <gregkh@...uxfoundation.org> CC: <dri-devel@...ts.freedesktop.org>, David Airlie <airlied@...ux.ie>, Jerome Glisse <j.glisse@...il.com>, Joerg Roedel <joro@...tes.org>, <linux-kernel@...r.kernel.org>, John Bridgman <John.Bridgman@....com>, <Alexander.Deucher@....com> Subject: Re: [PATCH 1/3] amdkfd: Don't clear *kfd2kgd on kfd_module_init On 12/20/2014 11:25 PM, Greg KH wrote: > On Sat, Dec 20, 2014 at 10:46:12PM +0200, Oded Gabbay wrote: >> When amdkfd and radeon are compiled inside the kernel image (not as modules), >> radeon will load before amdkfd and will set *kfd2kgd to its interface >> structure. Therefore, we must not set *kfd2kgd to NULL when amdkfd is loaded >> because it will override radeon's initialization and cause kernel BUG. >> >> Signed-off-by: Oded Gabbay <oded.gabbay@....com> >> --- >> drivers/gpu/drm/amd/amdkfd/kfd_module.c | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_module.c b/drivers/gpu/drm/amd/amdkfd/kfd_module.c >> index 95d5af1..236562f 100644 >> --- a/drivers/gpu/drm/amd/amdkfd/kfd_module.c >> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_module.c >> @@ -34,7 +34,7 @@ >> #define KFD_DRIVER_MINOR 7 >> #define KFD_DRIVER_PATCHLEVEL 0 >> >> -const struct kfd2kgd_calls *kfd2kgd; >> +const struct kfd2kgd_calls *kfd2kgd = NULL; > > This change does nothing, that is what the original code did already. > > thanks, > > greg k-h Yeah. Sorry, I will remove it. Oded > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists