linux-kernel - Re: [PATCH] [TRIVIAL] IBM Akebono: Remove select of IBM_EMAC_RGMII

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1419243273.30945.19.camel@x220>
Date:	Mon, 22 Dec 2014 11:14:33 +0100
From:	Paul Bolle <pebolle@...cali.nl>
To:	Jiri Kosina <trivial@...nel.org>
Cc:	Valentin Rothberg <valentinrothberg@...il.com>,
	Alistair Popple <alistair@...ple.id.au>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [TRIVIAL] IBM Akebono: Remove select of
 IBM_EMAC_RGMII_WOL

Hi Jiri,

On Mon, 2014-11-03 at 10:52 +0100, Paul Bolle wrote:
> Commit 2a2c74b2efcb ("IBM Akebono: Add the Akebono platform") added a
> select of IBM_EMAC_RGMII_WOL. But that Kconfig symbol isn't (yet) part
> of the tree. So this select has been a nop since that commit was
> included in v3.16-rc1.
> 
> The code to add this symbol is not included in next-20141103. So let's
> remove this select. It can be readded when that symbol is actually added
> to the tree.
> 
> Signed-off-by: Paul Bolle <pebolle@...cali.nl>
> Cc: Alistair Popple <alistair@...ple.id.au>
> ---
> Untested. Done on top of next-20141103.
> 
> Third time's a charm? First raised in
> https://lkml.org/lkml/2014/5/1/106 . Reminder sent in
> https://lkml.org/lkml/2014/9/4/645 . I'm not aware of any news on this
> front, so this trivial patch seems reasonable now.
> 
> A patch to readd this select could be added - if people still care about
> it, that is - in the series that adds this symbol. A web search suggests
> Alistair takes care of that series, so Alistair gets a Cc: here.

This select of IBM_EMAC_RGMII_WOL still shows up in next-20141221 and
v3.19-rc1. Did you have a chance to look at this patch?

>  arch/powerpc/platforms/44x/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/powerpc/platforms/44x/Kconfig b/arch/powerpc/platforms/44x/Kconfig
> index d2ac1c116454..5538e57c36c1 100644
> --- a/arch/powerpc/platforms/44x/Kconfig
> +++ b/arch/powerpc/platforms/44x/Kconfig
> @@ -214,7 +214,6 @@ config AKEBONO
>  	select ETHERNET
>  	select NET_VENDOR_IBM
>  	select IBM_EMAC_EMAC4
> -	select IBM_EMAC_RGMII_WOL
>  	select USB if USB_SUPPORT
>  	select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD
>  	select USB_EHCI_HCD_PLATFORM if USB_EHCI_HCD

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/