lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 22 Dec 2014 16:07:07 +0100
From:	Jiri Olsa <>
To:	Arnaldo Carvalho de Melo <>
Cc:	Rickard Strandqvist <>,
	Jiri Olsa <>,
	Namhyung Kim <>,,
Subject: Re: [PATCH] tools: lib: traceevent: event-parse.c:  Remove some
 unused functions

On Mon, Dec 22, 2014 at 12:52:10PM -0200, Arnaldo Carvalho de Melo wrote:
> Em Sat, Dec 20, 2014 at 01:45:41PM +0100, Rickard Strandqvist escreveu:
> > Removes some functions that are not used anywhere:
> > pevent_get_any_field_val() pevent_get_common_field_val() pevent_event_fields() pevent_event_common_fields() pevent_list_events() pevent_print_event() pevent_data_event_from_type() pevent_register_trace_clock() pevent_pid_is_registered()
> > 
> > This was partially found by using a static code analysis program called cppcheck.
> Steven, Namhyung, Jiri:
> Are you ok with me applying this patch? I'm all for it, dead code better
> be removed, but I don't know what are your plans wrt synchronization
> with the trace-cmd repo.

I'm not aware about more porting from traceevent lib, but I'm
guessing there's still lot of things missing..?

However, if we go with the removal, this patch has same
issue as the other one.. missing removal of functions
used only in removed code:

  CC FPIC  event-parse.o
/home/jolsa/ warning: ‘is_timestamp_in_us’ defined but not used [-Wunused-function]
 static bool is_timestamp_in_us(char *trace_clock, bool use_trace_clock)
/home/jolsa/ warning: ‘events_name_cmp’ defined but not used [-Wunused-function]
 static int events_name_cmp(const void *a, const void *b)
/home/jolsa/ warning: ‘events_system_cmp’ defined but not used [-Wunused-function]
 static int events_system_cmp(const void *a, const void *b)
/home/jolsa/ warning: ‘get_event_fields’ defined but not used [-Wunused-function]
 get_event_fields(const char *type, const char *name,
  CC FPIC  event-plugin.o

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists