linux-kernel - Re: Question about error handling for the function,disk_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <549855B5.6050805@kernel.dk>
Date:	Mon, 22 Dec 2014 10:32:37 -0700
From:	Jens Axboe <axboe@...nel.dk>
To:	nick <xerofoify@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: Question about error handling for the function,disk_add_events
 in genhd.c

On 12/22/2014 10:28 AM, nick wrote:
> Greetings Again Jen,
> I am wondering about the fix me message here:
>   /* FIXME: error handling */
> related to error handling. Seems the below code:
>   if (sysfs_create_files(&disk_to_dev(disk)->kobj, disk_events_attrs) < 0)
>                  pr_warn("%s: failed to create sysfs files for events\n",
>                       disk->disk_name);
> handles this fine. I am going to remove the comment unless we need to
> rewrite this function.

Again, spewing a warning when the error triggers and marching is not 
"handles this fine", it only qualifies as "doesn't blatantly ignore an 
error". Please spend some time studying up on what error handling is, 
I'm not even going to look at potential patches or further musings on 
this topic until you have done that.


-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/