linux-kernel - Re: [PATCH v4 1/2] spi: Add new driver for STMicroelectronics' SPI Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141222183622.GI17800@sirena.org.uk>
Date:	Mon, 22 Dec 2014 18:36:22 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	kernel@...inux.com, linux-spi@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH v4 1/2] spi: Add new driver for STMicroelectronics' SPI
 Controller

On Tue, Dec 09, 2014 at 08:21:30PM +0000, Lee Jones wrote:
> This patch adds support for the SPI portion of ST's SSC device.

I've applied both of these, though I had to rename the DT binding
document and...

> +static int spi_st_clk_enable(struct spi_st *spi_st)
> +{
> +	/*
> +	 * Current platforms use one of the core clocks for SPI and I2C.
> +	 * If we attempt to disable the clock, the system will hang.
> +	 *
> +	 * TODO: Remove this when platform supports power domains.
> +	 */
> +	return 0;
> +
> +	return clk_prepare_enable(spi_st->clk);
> +}

...this is not good at all and a step back from the previous version -
if there are problems with the SoC integration they need to be fixed
there or possibly in the clock driver for the SoC rather than bodging
individual drivers.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)