lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 22 Dec 2014 11:18:52 +0800
From:	Jiang Liu <jiang.liu@...ux.intel.com>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>
CC:	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Christoph Lameter <cl@...ux.com>, Tejun Heo <tj@...nel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arch: x86: kernel: apb_timer.c:  Remove unused function

On 2014/12/21 20:58, Rickard Strandqvist wrote:
> Remove the function is_apbt_capable() that is not used anywhere.
> 
> This was partially found by using a static code analysis program called cppcheck.
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> ---
>  arch/x86/kernel/apb_timer.c |    8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/arch/x86/kernel/apb_timer.c b/arch/x86/kernel/apb_timer.c
> index b708738..6a7c23f 100644
> --- a/arch/x86/kernel/apb_timer.c
> +++ b/arch/x86/kernel/apb_timer.c
> @@ -135,14 +135,6 @@ static inline void apbt_clear_mapping(void)
>  	apbt_virt_address = NULL;
>  }
>  
> -/*
> - * APBT timer interrupt enable / disable
> - */
> -static inline int is_apbt_capable(void)
> -{
> -	return apbt_virt_address ? 1 : 0;
> -}
> -
>  static int __init apbt_clockevent_register(void)
>  {
>  	struct sfi_timer_table_entry *mtmr;
> 
Reviewed-by: Jiang Liu <jiang.liu@...ux.intel.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists