linux-kernel - Re: [PATCH] lib: proportions.c: Remove some unused functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20141222132626.2697567529c7708804c4061a@linux-foundation.org>
Date:	Mon, 22 Dec 2014 13:26:26 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc:	Tejun Heo <tj@...nel.org>, Jan Kara <jack@...e.cz>,
	"David S. Miller" <davem@...emloft.net>,
	linux-kernel@...r.kernel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH] lib: proportions.c:  Remove some unused functions

On Sat, 20 Dec 2014 15:51:53 +0100 Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> wrote:

> Removes some functions that are not used anywhere:
> prop_change_shift() prop_descriptor_init() prop_fraction_percpu() prop_fraction_single() __prop_inc_percpu_max() prop_local_destroy_percpu() prop_local_destroy_single() prop_local_init_percpu() prop_local_init_single()
> 
> This was partially found by using a static code analysis program called cppcheck.
> 
> ---
>  include/linux/proportions.h |   14 ----
>  lib/proportions.c           |  177 -------------------------------------------
>  2 files changed, 191 deletions(-)

Gee, that's a heck of a lot of dead code.

Peter, what was the thinking here?  Was this code once used, or added
for API completeness or what?

Perhaps we should just ifdef it out, so the code is still sitting there if
someone wishes to resurrect it.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/