linux-kernel - Re: [PATCH] proc: task_mmu: show page size in /proc/<pid>/numa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1412221420170.11431@chino.kir.corp.google.com>
Date:	Mon, 22 Dec 2014 14:21:35 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Dave Hansen <dave.hansen@...ux.intel.com>
cc:	Rafael Aquini <aquini@...hat.com>,
	Johannes Weiner <hannes@...xchg.org>,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	oleg@...hat.com, linux-mm@...ck.org, Mel Gorman <mel@....ul.ie>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Subject: Re: [PATCH] proc: task_mmu: show page size in
 /proc/<pid>/numa_maps

On Mon, 22 Dec 2014, Dave Hansen wrote:

> > Remaining question here is: should we print out 'pagesize' deliberately 
> > or conditionally, only to disambiguate cases where page_size != PAGE_SIZE?
> 
> I say print it unconditionally.  Not to completely overdesign this, but
> I do think we should try to at least mirror the terminology that smaps uses:
> 
> 	KernelPageSize:        4 kB
> 	MMUPageSize:           4 kB
> 
> So definitely call this kernelpagesize.
> 

Feel free to add my acked-by if this patch prints it unconditionally and 
renames this to kernelpagesize per Dave.  I agree we need to leave "huge" 
for existing dependencies even though we have multiple possible hugepage 
sizes.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/