lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 21 Dec 2014 23:12:16 -0800 From: Omar Sandoval <osandov@...ndov.com> To: Al Viro <viro@...IV.linux.org.uk> Cc: Andrew Morton <akpm@...ux-foundation.org>, Trond Myklebust <trond.myklebust@...marydata.com>, Christoph Hellwig <hch@...radead.org>, linux-fsdevel@...r.kernel.org, linux-mm@...ck.org, linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org, Ming Lei <ming.lei@...onical.com> Subject: Re: [PATCH v2 2/5] direct-io: don't dirty ITER_BVEC pages on read On Sat, Dec 20, 2014 at 06:01:30AM +0000, Al Viro wrote: > On Fri, Dec 19, 2014 at 07:18:26PM -0800, Omar Sandoval wrote: > > Reads through the iov_iter infrastructure for kernel pages shouldn't be > > dirtied by the direct I/O code. > > > > This is based on Dave Kleikamp's and Ming Lei's previously posted > > patches. > > Umm... > > > + dio->should_dirty = !iov_iter_is_bvec(iter); > > dio->should_dirty = iter_is_iovec(iter); > > perhaps? Mm, yeah, I'll do that. That helper snuck in without me noticing it... I see that we can't do iov_iter_get_pages on an ITER_KVEC, so a kvec doesn't work for blockdev_direct_IO anyways, right? -- Omar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists