linux-kernel - Re: Cleaning up the KVM clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <54994304.1060808@redhat.com>
Date:	Tue, 23 Dec 2014 11:25:08 +0100
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Santosh Shukla <sshukla@...sta.com>
CC:	Andy Lutomirski <luto@...capital.net>,
	Marcelo Tosatti <mtosatti@...hat.com>,
	Gleb Natapov <gleb@...nel.org>, kvm list <kvm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: Cleaning up the KVM clock



On 23/12/2014 11:23, Santosh Shukla wrote:
> 
> 
>     No.  kvm_guest_time_update is called by vcpu_enter_guest, while the vCPU
>     is not running, so it's entirely atomic from the point of view of
>     the guest.
> 
>  
> Then checking odd value for version field (at guest side: function
> pvclock_clocksource_read / pvclock_read_flag) is redundant considering
> that  kvm_guest_time_update incremented by 2. 

The code is common to Xen and KVM.  Xen uses seqlock semantics.  The
cost of one AND is not detectable.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/