linux-kernel - Re: [RFC PATCH 02/17] block: simplify bio_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141223114641.GC15080@gmail.com>
Date:	Tue, 23 Dec 2014 12:46:41 +0100
From:	Dongsu Park <dongsu.park@...fitbricks.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	linux-kernel@...r.kernel.org, Jens Axboe <axboe@...nel.dk>,
	Kent Overstreet <kmo@...erainc.com>,
	Ming Lin <mlin@...ggr.net>, target-devel@...r.kernel.org,
	Boaz Harrosh <ooo@...ctrozaur.com>,
	Benny Halevy <bhalevy@...marydata.com>
Subject: Re: [RFC PATCH 02/17] block: simplify bio_add_page()

On 23.12.2014 02:22, Christoph Hellwig wrote:
> On Mon, Dec 22, 2014 at 12:48:29PM +0100, Dongsu Park wrote:
> > From: Kent Overstreet <kmo@...erainc.com>
> > 
> > Since generic_make_request() can now handle arbitrary size bios, all we
> > have to do is make sure the bvec array doesn't overflow.
> > __bio_add_page() doesn't need to call ->merge_bvec_fn(), where
> > we can get rid of unnecessary code paths.
> 
> This needs an explanation of why removign the call to ->merge_bvec_fn
> is fine for bio_add_pc_page.  I guess it's because neither
> the target pscsi pass through mode, nor the osd code ever use anything
> but a simple scsi devices that doesn't even have one, but it needs to be
> clearly spelled out.

Agreed.

> > + *	Attempt to add a page to the bio_vec maplist. This will only fail if
> > + *	bio->bi_vcnt == bio->bi_max_vecs.
> 
> It also fails on a cloned bio, although that might better be turned into
> a BUG_ON().

Agreed, I'll update both of them in the next round.

Thanks,
Dongsu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/