linux-kernel - Re: [PATCH] checkpatch: fix UNNECESSARY_KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1419340466.18020.7.camel@perches.com>
Date:	Tue, 23 Dec 2014 05:14:26 -0800
From:	Joe Perches <joe@...ches.com>
To:	Paolo Bonzini <pbonzini@...hat.com>
Cc:	linux-kernel@...r.kernel.org, Andy Whitcroft <apw@...onical.com>
Subject: Re: [PATCH] checkpatch: fix UNNECESSARY_KERN_LEVEL false positive

On Tue, 2014-12-23 at 14:02 +0100, Paolo Bonzini wrote:
> KERN_<LEVEL> is never redundant with printk_ratelimited.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -4545,7 +4545,7 @@ sub process {
>  		}
>  
>  # check for logging functions with KERN_<LEVEL>
> -		if ($line !~ /printk\s*\(/ &&
> +		if ($line !~ /printk(?:_ratelimited)?\s*\(/ &&

Seems sensible bu this should probably add _once too

		if ($line !~ /printk(?:_ratelimited|_once)?\s*\(/ &&

Please add and resubmit cc'ing Andrew Morton too.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/