linux-kernel - Re: [PATCH 1/1 net-next] netfilter: remove unnecessary sizeof(char)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141223133338.GA15456@salvia>
Date:	Tue, 23 Dec 2014 14:33:38 +0100
From:	Pablo Neira Ayuso <pablo@...filter.org>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel@...r.kernel.org, davem@...emloft.net, joe@...ches.com,
	Patrick McHardy <kaber@...sh.net>,
	Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
	netfilter-devel@...r.kernel.org, coreteam@...filter.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH 1/1 net-next] netfilter: remove unnecessary sizeof(char)

On Mon, Dec 22, 2014 at 07:36:15PM +0100, Fabian Frederick wrote:
> sizeof(char) is always 1.

Applied, thanks.

Made a small change on it:

> Suggested-by: Joe Perches <joe@...ches.com>
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
>  net/netfilter/nf_log.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/netfilter/nf_log.c b/net/netfilter/nf_log.c
> index 43c926c..1191f66 100644
> --- a/net/netfilter/nf_log.c
> +++ b/net/netfilter/nf_log.c
> @@ -426,7 +426,7 @@ static int netfilter_log_sysctl_init(struct net *net)
>  				nf_log_sysctl_fnames[i];
>  			nf_log_sysctl_table[i].data = NULL;
>  			nf_log_sysctl_table[i].maxlen =
> -				NFLOGGER_NAME_LEN * sizeof(char);
> +				NFLOGGER_NAME_LEN;

this now fits in one line (80-chars).

>  			nf_log_sysctl_table[i].mode = 0644;
>  			nf_log_sysctl_table[i].proc_handler =
>  				nf_log_proc_dostring;
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/