linux-kernel - Re: [PATCH 0/3] clk: samsung: Use samsung_cmu_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <54997113.2080804@samsung.com>
Date:	Tue, 23 Dec 2014 14:41:39 +0100
From:	Sylwester Nawrocki <s.nawrocki@...sung.com>
To:	Chanwoo Choi <cw00.choi@...sung.com>
Cc:	tomasz.figa@...il.com, kgene.kim@...sung.com,
	kyungmin.park@...sung.com, inki.dae@...sung.com,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3]  clk: samsung: Use samsung_cmu_register_one() to
 simplify code

Hi Chanwoo,

On 23/12/14 08:40, Chanwoo Choi wrote:
> This patch-set uses the samsung_cmu_register_one() function to simplify the
> clock driver for Exynos3250/Exynos4415 SoC and change return value of
> samsung_cmu_register_one() because some clock driver may need the instance
> of samsung_clk_provider structure.
> 
> Chanwoo Choi (3):
>   clk: samsung: Changes the return value of samsung_cmu_register_one()
>   clk: samsung: exynos3250: Use samsung_cmu_register_one() to simplify code
>   clk: samsung: exynos4415: Use samsung_cmu_register_one() to simplify code
> 
>  drivers/clk/samsung/clk-exynos3250.c | 217 ++++++++---------------------------
>  drivers/clk/samsung/clk-exynos4415.c | 216 ++++++++--------------------------
>  drivers/clk/samsung/clk.c            |  13 ++-
>  drivers/clk/samsung/clk.h            |   3 +-
>  4 files changed, 107 insertions(+), 342 deletions(-)

Thanks for the cleanup, I've queued that for 3.20. And fixed a minor
checkpatch warning when applying:

ERROR: "foo* __init bar" should be "foo * __init bar"
#29: FILE: drivers/clk/samsung/clk.c:377:
+struct samsung_clk_provider* __init samsung_cmu_register_one(

total: 1 errors, 0 warnings, 42 lines checked

0001-clk-samsung-Changes-the-return-value-of-samsung_cmu_.patch has style
problems, please review.

-- 
Thanks,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/