linux-kernel - Re: [PATCH 2/3] mmc: host: don't use devm_pinctrl_get_select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDyKFrroxHw4qm4GRE2C1iWgf5_-P4W3O9Mxf-7vgg7pXiGqA@mail.gmail.com>
Date:	Tue, 23 Dec 2014 16:37:52 +0100
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Wolfram Sang <wsa@...-dreams.de>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	Nicolas Pitre <nico@...xnic.net>,
	Chris Ball <chris@...ntf.net>,
	linux-mmc <linux-mmc@...r.kernel.org>
Subject: Re: [PATCH 2/3] mmc: host: don't use devm_pinctrl_get_select_default()
 in probe

On 22 December 2014 at 23:16, Wolfram Sang <wsa@...-dreams.de> wrote:
> Since commit ab78029ecc34 (drivers/pinctrl: grab default handles from device
> core), we can rely on device core for setting the default pins.
>
> Signed-off-by: Wolfram Sang <wsa@...-dreams.de>

Thanks! Applied for next, with an updated prefix of the commit header
to "mmc: mvsdio:".

Kind regards
Uffe

> ---
>  drivers/mmc/host/mvsdio.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c
> index 4f8618f4522d..a2cb92851f1f 100644
> --- a/drivers/mmc/host/mvsdio.c
> +++ b/drivers/mmc/host/mvsdio.c
> @@ -25,7 +25,6 @@
>  #include <linux/of_irq.h>
>  #include <linux/mmc/host.h>
>  #include <linux/mmc/slot-gpio.h>
> -#include <linux/pinctrl/consumer.h>
>
>  #include <asm/sizes.h>
>  #include <asm/unaligned.h>
> @@ -704,7 +703,6 @@ static int mvsd_probe(struct platform_device *pdev)
>         const struct mbus_dram_target_info *dram;
>         struct resource *r;
>         int ret, irq;
> -       struct pinctrl *pinctrl;
>
>         r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>         irq = platform_get_irq(pdev, 0);
> @@ -721,10 +719,6 @@ static int mvsd_probe(struct platform_device *pdev)
>         host->mmc = mmc;
>         host->dev = &pdev->dev;
>
> -       pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
> -       if (IS_ERR(pinctrl))
> -               dev_warn(&pdev->dev, "no pins associated\n");
> -
>         /*
>          * Some non-DT platforms do not pass a clock, and the clock
>          * frequency is passed through platform_data. On DT platforms,
> --
> 2.1.3
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/