lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:	Tue, 23 Dec 2014 21:14:31 -0500
From:	Ed Cashin <ecashin@...erose.net>
To:	Nicholas Mc Guire <der.herr@...r.at>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] incorrect use of init_completion fixup

On Tue, Dec 23, 2014 at 12:44 PM, Nicholas Mc Guire <der.herr@...r.at> wrote:
>
> The second init_completion call should be a reinit_completion here.
>
> patch is against 3.18.0 linux-next
>
> Signed-off-by: Nicholas Mc Guire <der.herr@...r.at>
> ---
>  drivers/block/aoe/aoecmd.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c
> index 422b7d8..2239513 100644
> --- a/drivers/block/aoe/aoecmd.c
> +++ b/drivers/block/aoe/aoecmd.c
> @@ -1331,7 +1331,7 @@ aoe_ktstart(struct ktstate *k)
>                 return -ENOMEM;
>         k->task = task;
>         wait_for_completion(&k->rendez); /* allow kthread to start */
> -       init_completion(&k->rendez);    /* for waiting for exit later */
> +       reinit_completion(&k->rendez);  /* for waiting for exit later */
>         return 0;
>  }

That looks good to me, thanks.

-- 
  Ed Cashin <ecashin@...erose.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists