linux-kernel - [PATCH] clk-gate: fix bit # check in clk_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <2500887.6mMDBajo0S@wasted.cogentembedded.com>
Date:	Wed, 24 Dec 2014 17:43:27 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	mturquette@...aro.org, linux-kernel@...r.kernel.org,
	sboyd@...eaurora.org
Cc:	linux-sh@...r.kernel.org
Subject: [PATCH] clk-gate: fix bit # check in clk_register_gate()

In case CLK_GATE_HIWORD_MASK flag is passed to clk_register_gate(), the bit #
should be no higher than 15, however the corresponding check is obviously off-
by-one.

Fixes: 045779942c04 ("clk: gate: add CLK_GATE_HIWORD_MASK")
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>

---
The patch is against Linus' repo because the 'clk-fixes' branch  in  Mike
Turquette's 'linux.git' repo at Linaro seems very outdated. BTW, the repo
at kernel.org specified by the MAINTAINERS file doesn't seem to exist --
can something be done about that?

 drivers/clk/clk-gate.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/drivers/clk/clk-gate.c
===================================================================
--- linux.orig/drivers/clk/clk-gate.c
+++ linux/drivers/clk/clk-gate.c
@@ -128,7 +128,7 @@ struct clk *clk_register_gate(struct dev
 	struct clk_init_data init;
 
 	if (clk_gate_flags & CLK_GATE_HIWORD_MASK) {
-		if (bit_idx > 16) {
+		if (bit_idx > 15) {
 			pr_err("gate bit exceeds LOWORD field\n");
 			return ERR_PTR(-EINVAL);
 		}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/