linux-kernel - Re: [PATCH] openvswitch: fix odd_ptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALnjE+qNmBekeS_vbSx23myvocShRE1mZ6nHew3Hr=dQt=rHSw@mail.gmail.com>
Date:	Wed, 24 Dec 2014 10:49:22 -0800
From:	Pravin Shelar <pshelar@...ira.com>
To:	kbuild test robot <fengguang.wu@...el.com>
Cc:	kbuild-all@...org, "dev@...nvswitch.org" <dev@...nvswitch.org>,
	netdev <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] openvswitch: fix odd_ptr_err.cocci warnings

On Tue, Dec 23, 2014 at 10:41 PM, kbuild test robot
<fengguang.wu@...el.com> wrote:
> net/openvswitch/vport-gre.c:188:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 189
>
>  PTR_ERR should access the value just tested by IS_ERR
>
> Semantic patch information:
>  There can be false positives in the patch case, where it is the call
>  IS_ERR that is wrong.
>
> Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
>
> CC: Pravin B Shelar <pshelar@...ira.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>

Thanks for the fix.

Acked-by: Pravin B Shelar <pshelar@...ira.com>

> ---
>
>  vport-gre.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/net/openvswitch/vport-gre.c
> +++ b/net/openvswitch/vport-gre.c
> @@ -186,7 +186,7 @@ static int gre_tnl_send(struct vport *vp
>         /* Push Tunnel header. */
>         skb = __build_header(skb, tunnel_hlen);
>         if (IS_ERR(skb)) {
> -               err = PTR_ERR(rt);
> +               err = PTR_ERR(skb);
>                 skb = NULL;
>                 goto err_free_rt;
>         }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/