linux-kernel - Re: [PATCH] ARM: socfpga: dts: Add adxl34x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 24 Dec 2014 20:11:00 -0300
From:	Walter Lozano <walter@...guardiasur.com.ar>
To:	Steffen Trumtrar <s.trumtrar@...gutronix.de>
Cc:	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, Kumar Gala <galak@...eaurora.org>,
	linux@....linux.org.uk, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: socfpga: dts: Add adxl34x

On Wed, Dec 24, 2014 at 6:45 AM, Steffen Trumtrar
<s.trumtrar@...gutronix.de> wrote:
> Hi!
>
> On Tue, Dec 23, 2014 at 10:04:22AM -0300, Walter Lozano wrote:
>> This patch adds the DTS bindings for the adxl34x digital
>> accelerometer.
>>
>
> Thanks for doing this. Does the ADXL34 work now? Last time I
> tried it, I didn't get any interrupts, but as I didn't really
> care for the accelerometer I didn't dig deeper.

Yes, now it works. There was a problem with the interrupts as the gpio was
probed after i2c. I have done some patches to fix this but some else
did a better job
deferring the probe so now it work out of the box.

>> Signed-off-by: Walter Lozano <walter@...guardiasur.com.ar>
>> ---
>>  arch/arm/boot/dts/socfpga_cyclone5_sockit.dts |   17 +++++++++++++++++
>>  1 file changed, 17 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
>> index 16ea6f5..f99d7dec 100644
>> --- a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
>> +++ b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
>> @@ -68,3 +68,20 @@
>>  &usb1 {
>>       status = "okay";
>>  };
>> +
>> +&gpio2 {
>> +     status = "okay";
>> +};
>> +
>> +&i2c1{
>        ^^^
>
> Add a space here and ...
>
>> +     status = "okay";
>> +
>> +     accel1: accel1@53{
>                         ^^^
> here. Also, this should be accelerometer@53.
>
>> +             compatible = "adxl34x";
>> +             reg = <0x53>;
>> +
>> +             interrupt-parent = < &portc >;
>                                    ^^^    ^^^
> Please remove the spaces here.
>> +             interrupts = <3 2>;
>> +
>> +     };
>> +};
>
> Finally, please sort the nodes alphabetically and not just append them.

Great, no problem at all. Thanks for the corrections.

Regards,

Walter

-- 
Walter Lozano, VanguardiaSur
www.vanguardiasur.com.ar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/