[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1419399572.6157.7.camel@perches.com>
Date: Tue, 23 Dec 2014 21:39:32 -0800
From: Joe Perches <joe@...ches.com>
To: Rohith Seelaboyina <rseelaboyina@...dia.com>
Cc: balbi@...com, gregkh@...uxfoundation.org, mina86@...a86.com,
r.baldyga@...sung.com, andrzej.p@...sung.com,
david.a.cohen@...ux.intel.com, linux-usb@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: ffs: Fix sparse error
On Wed, 2014-12-24 at 10:59 +0530, Rohith Seelaboyina wrote:
> Dynamic memory allocation through kmalloc is more safer
> than declaring variable array size, Fix this error by
> using kmalloc for memory allocation, Check if memory
> allocation is successful and return -ENOMEM on failure.
[]
> diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c
[]
> @@ -397,10 +397,15 @@ static ssize_t __ffs_ep0_read_events(struct ffs_data *ffs, char __user *buf,
> * We are holding ffs->ev.waitq.lock and ffs->mutex and we need
> * to release them.
> */
> - struct usb_functionfs_event events[n];
> unsigned i = 0;
> + int ret;
> + struct usb_functionfs_event *events = kmalloc(n *
> + sizeof(struct usb_functionfs_event), GFP_KERNEL);
> +
> + if (unlikely(!events))
> + return -ENOMEM;
>
> - memset(events, 0, sizeof events);
> + memset(events, 0, n * sizeof(*events));
kcalloc without memset please.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists