linux-kernel - Re: [PATCH 5/8] irqchip: Conexant CX92755 interrupts controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141224061657.GI2481@sapphire.tkos.co.il>
Date:	Wed, 24 Dec 2014 08:16:57 +0200
From:	Baruch Siach <baruch@...s.co.il>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linux-arm-kernel@...ts.infradead.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Jason Cooper <jason@...edaemon.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/8] irqchip: Conexant CX92755 interrupts controller
 driver

Hi Arnd,

On Tue, Dec 23, 2014 at 10:02:18PM +0100, Arnd Bergmann wrote:
> On Tuesday 23 December 2014 09:58:42 Baruch Siach wrote:
> > +static void __exception_irq_entry digicolor_handle_irq(struct pt_regs *regs)
> > +{
> > +       u32 status, hwirq;
> > +
> > +       do {
> > +               status = readl(digicolor_irq_base + IC_INT0STATUS_LO);
> > +               if (status) {
> > +                       hwirq = ffs(status) - 1;
> > +               } else {
> > +                       status = readl(digicolor_irq_base + IC_INT0STATUS_XLO);
> > +                       if (status)
> > +                               hwirq = ffs(status) - 1 + 32;
> > +                       else
> > +                               return;
> > +               }
> > +
> > +               handle_domain_irq(digicolor_irq_domain, hwirq, regs);
> > +       } while (1);
> > +}
> > 
> 
> Have you tried using the generic_irqchip code for this? The hardware
> seems simple enough.

Thanks for the tip. I'll look into converting to GENERIC_IRQ_CHIP for next 
version.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@...s.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/